Enhancement show total items #221
Closed
+104
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ber of items filtered from the table.
Wright, Tyler Jordan (wrigh393)
requested a review
from Justin Tyler Campbell (campb303)
Wright, Tyler Jordan (wrigh393)
linked an issue
Collaborator
Justin Tyler Campbell (campb303)
left a comment
Justin Tyler Campbell (campb303)
left a comment
There was a problem hiding this comment.
No issues with the code at this point. Per #152 (comment) this architecture will e replaced with a new approach.
| @@ -98,6 +98,11 @@ export default function ItemTable({ data, rowCanBeSelected, loading }) { | |||
| ); | |||
| const { getTableProps, getTableBodyProps, headerGroups, rows, prepareRow, } = tableInstance; | |||
|
|
|||
| //Sets filteredItems length when items are filtered from the table/ | |||
Collaborator
There was a problem hiding this comment.
Add space between comment marker and comment content.
- //Sets...
+ // Sets...| setValue={setSelectedQueues} | ||
| /> | ||
| </Box> | ||
| <ItemCounter filteredItems={filteredItems} totalItems={items.length} /> |
Collaborator
There was a problem hiding this comment.
It'd be better to use the autocalculated value from the react-table instance inside ItemTable than the derived value from here to insure the count is kept in sync with what the UI reflects.
Collaborator
|
Closing to be replaced with another branch. |
Justin Tyler Campbell (campb303)
deleted the
enhancement-show-total-items
branch
Sign in
to join this conversation on GitHub.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152